From 488667a3c84e97b4f4b5b320b248ff397fb83bdb Mon Sep 17 00:00:00 2001 From: btrezzy <128296263+btrezzy@users.noreply.github.com> Date: Thu, 15 Aug 2024 01:22:01 +0530 Subject: [PATCH 1/4] Fix information exposure through logger --- website/views.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/website/views.py b/website/views.py index b89e3ad3d..54488bd48 100644 --- a/website/views.py +++ b/website/views.py @@ -8,6 +8,7 @@ import urllib.parse import urllib.request import uuid +import logging from collections import deque from datetime import datetime, timedelta, timezone from decimal import Decimal @@ -137,6 +138,8 @@ # Load environment variables load_dotenv() +logger = logging.getLogger(__name__) + @login_required def profile_edit(request): @@ -4823,7 +4826,8 @@ def chatbot_conversation(request): try: response = crc.invoke({"question": question}) except Exception as e: - error_message = f"Error: {str(e)}" + logger.error(f"An error occurred: {str(e)}") + error_message = "An unexpected error occurred. Please try again later" ChatBotLog.objects.create(question=question, answer=error_message) return Response({"error": error_message}, status=status.HTTP_500_INTERNAL_SERVER_ERROR) # Increment the request count @@ -4836,7 +4840,8 @@ def chatbot_conversation(request): return Response({"answer": response["answer"]}, status=status.HTTP_200_OK) except Exception as e: - error_message = f"Error: {str(e)}" + logger.error(f"An error occurred: {str(e)}") + error_message = "An unexpected error occurred. Please try again later" ChatBotLog.objects.create(question=request.data.get("question", ""), answer=error_message) return Response({"error": error_message}, status=status.HTTP_500_INTERNAL_SERVER_ERROR) From 12e74ebb9c0f6a606c05db0c8404fb1886d7c7a6 Mon Sep 17 00:00:00 2001 From: btrezzy <128296263+btrezzy@users.noreply.github.com> Date: Thu, 15 Aug 2024 02:17:56 +0530 Subject: [PATCH 2/4] Fix import order with isort --- website/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/views.py b/website/views.py index 54488bd48..07aa47902 100644 --- a/website/views.py +++ b/website/views.py @@ -1,6 +1,7 @@ import base64 import io import json +import logging import os import re import time @@ -8,7 +9,6 @@ import urllib.parse import urllib.request import uuid -import logging from collections import deque from datetime import datetime, timedelta, timezone from decimal import Decimal From ba1f88c2ba84fe66cefd215167906c6ade0be75e Mon Sep 17 00:00:00 2001 From: Nirajkumar Patel <128296263+npxpatel@users.noreply.github.com> Date: Sat, 17 Aug 2024 12:35:08 +0530 Subject: [PATCH 3/4] Update website/views.py Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> --- website/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/views.py b/website/views.py index 07aa47902..100b785b6 100644 --- a/website/views.py +++ b/website/views.py @@ -4826,7 +4826,7 @@ def chatbot_conversation(request): try: response = crc.invoke({"question": question}) except Exception as e: - logger.error(f"An error occurred: {str(e)}") + logger.error(f"An error occurred: {e}") error_message = "An unexpected error occurred. Please try again later" ChatBotLog.objects.create(question=question, answer=error_message) return Response({"error": error_message}, status=status.HTTP_500_INTERNAL_SERVER_ERROR) From 82d11b24b8e9acb314df446cc89cba6be07b7a90 Mon Sep 17 00:00:00 2001 From: Nirajkumar Patel <128296263+npxpatel@users.noreply.github.com> Date: Sat, 17 Aug 2024 12:35:17 +0530 Subject: [PATCH 4/4] Update website/views.py Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> --- website/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/views.py b/website/views.py index 100b785b6..7bf4ed42e 100644 --- a/website/views.py +++ b/website/views.py @@ -4840,7 +4840,7 @@ def chatbot_conversation(request): return Response({"answer": response["answer"]}, status=status.HTTP_200_OK) except Exception as e: - logger.error(f"An error occurred: {str(e)}") + logger.error(f"An error occurred: {e}") error_message = "An unexpected error occurred. Please try again later" ChatBotLog.objects.create(question=request.data.get("question", ""), answer=error_message) return Response({"error": error_message}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)