payer plan period criteria support for circe-be #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marpozh
reviewed
Dec 29, 2017
| public NumericRange periodLength; | ||
|
|
||
| @JsonProperty("AgeAtStart") | ||
| public NumericRange ageAtstart; |
There was a problem hiding this comment.
@raomane, @gowthamrao - hello, do you mean "ageAtStart"?
marpozh
reviewed
Dec 29, 2017
| ArrayList<String> whereClauses = new ArrayList<>(); | ||
|
|
||
| //first | ||
| if (criteria.first != null && criteria.first == true) |
There was a problem hiding this comment.
I think ... && criteria.first is enough
There was a problem hiding this comment.
i think this is inline with other patterns.
e.g.
etc
chrisknoll
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to OHDSI/CommonDataModel#120
If/Once the proposal is accepted
@chrisknoll
OHDSI/WebAPI#217