-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create standard units for Measurement concepts #451
Comments
"When we convert some data, we need to store the original unit we converted from. So to Patrick, we do need to add a column to the CDM." Why is it in the vocabulary repo? |
The issue about the missing field in MEASUREMENT is here: OHDSI/CommonDataModel#259. |
Got it. |
Is LOINC gonna be alive once we implement this? |
Well, we can add units to whatever vocabulary is standard. For SNOMED it would be not so obvious as it doesn't specify the units nor even dimension. So these tasks needs to be done together. |
You mean, is it possible that SNOMED always wins and LOINC becomes the source concept? |
I don't know yet who wins, I'm just saying that it's tricky:) |
Yes. Not always, but for those top-something cases that we're able to enrich with units. I'd always prefer LOINC, except we have an uncertain source. For those cases, the SNOMED is also needed. So in fact, they're not duplicates 😃 How about this: we'll make those SNOMED classifications and will allow them to be used as the _concept_id? |
So, yes, let's work on this and the deduping one at the same time. |
I asked repeatedly LOINC leaders if they are willing to add it to LOINC (change example units) into CANONICAL units and the reply was: (pasted below)
|
Right, but the examples provided are highly relevant and the only thing we have to do is to pick one among others. |
It would be good to include Richard Moffit @rmoffitt from N3C in this conversation to learn what he's done standardize units in the OMOP instance there. |
We have concept sets for about 50 measurements, each with a selected unit. Then formulae to convert data from the other units to that one canonical unit. We store that in a new column, harmonized_value_as_number. |
How did you select one from others? |
We have many physicians on the team, so we relied on their experience when prioritizing which labs to harmonize as well as which canonical units to aim for. They were also central in our concept set review process. |
Great! Can you share it so that we can start thinking about making it a part of OMOP vocabulary? |
https://forums.ohdsi.org/t/converting-lab-results-into-preferred-unit-at-etl-time/11856
The text was updated successfully, but these errors were encountered: