Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standard units for Measurement concepts #451

Open
cgreich opened this issue Feb 9, 2021 · 16 comments
Open

Create standard units for Measurement concepts #451

cgreich opened this issue Feb 9, 2021 · 16 comments

Comments

@cgreich
Copy link
Contributor

cgreich commented Feb 9, 2021

https://forums.ohdsi.org/t/converting-lab-results-into-preferred-unit-at-etl-time/11856

@dimshitc
Copy link
Contributor

dimshitc commented Feb 10, 2021

"When we convert some data, we need to store the original unit we converted from.

So to Patrick, we do need to add a column to the CDM."

Why is it in the vocabulary repo?

@cgreich
Copy link
Contributor Author

cgreich commented Feb 10, 2021

The issue about the missing field in MEASUREMENT is here: OHDSI/CommonDataModel#259.
This is about creating a link between Measurement Concepts and Unit Concepts "Is measured in" and "used to measure".

@dimshitc
Copy link
Contributor

Got it.
@p-talapova had a plan to work on LOINC.
@mik-ohdsi let's plan it properly adding this task.

@Alexdavv
Copy link
Member

had a plan to work on LOINC.

Is LOINC gonna be alive once we implement this?

@dimshitc
Copy link
Contributor

Well, we can add units to whatever vocabulary is standard. For SNOMED it would be not so obvious as it doesn't specify the units nor even dimension. So these tasks needs to be done together.

@cgreich
Copy link
Contributor Author

cgreich commented Feb 10, 2021

You mean, is it possible that SNOMED always wins and LOINC becomes the source concept?

@dimshitc
Copy link
Contributor

I don't know yet who wins, I'm just saying that it's tricky:)

@Alexdavv
Copy link
Member

Alexdavv commented Feb 10, 2021

You mean, is it possible that SNOMED always wins and LOINC becomes the source concept?

Yes. Not always, but for those top-something cases that we're able to enrich with units.

I'd always prefer LOINC, except we have an uncertain source. For those cases, the SNOMED is also needed. So in fact, they're not duplicates 😃

How about this: we'll make those SNOMED classifications and will allow them to be used as the _concept_id?

@cgreich
Copy link
Contributor Author

cgreich commented Feb 10, 2021

So, yes, let's work on this and the deduping one at the same time.

@vojtechhuser
Copy link

I asked repeatedly LOINC leaders if they are willing to add it to LOINC (change example units) into CANONICAL units and the reply was: (pasted below)

As we discussed before, LOINC cannot include canonical UCUM units because the LOINC Property is one of the defining aspects of a given LOINC term, not the unit of measure, and each Property corresponds to multiple UCUM units. We can publish AoU and N3C UCUM lists on the UCUM website, but we can’t add them to the LOINC table as anything other than example units.

@Alexdavv
Copy link
Member

Alexdavv commented Feb 11, 2021

Right, but the examples provided are highly relevant and the only thing we have to do is to pick one among others.

@AEW0330
Copy link

AEW0330 commented May 28, 2021

It would be good to include Richard Moffit @rmoffitt from N3C in this conversation to learn what he's done standardize units in the OMOP instance there.

@rmoffitt
Copy link

We have concept sets for about 50 measurements, each with a selected unit. Then formulae to convert data from the other units to that one canonical unit. We store that in a new column, harmonized_value_as_number.

@Alexdavv
Copy link
Member

We have concept sets for about 50 measurements, each with a selected unit. Then formulae to convert data from the other units to that one canonical unit. We store that in a new column, harmonized_value_as_number.

How did you select one from others?

@rmoffitt
Copy link

We have many physicians on the team, so we relied on their experience when prioritizing which labs to harmonize as well as which canonical units to aim for. They were also central in our concept set review process.

@Alexdavv
Copy link
Member

We have many physicians on the team, so we relied on their experience when prioritizing which labs to harmonize as well as which canonical units to aim for. They were also central in our concept set review process.

Great! Can you share it so that we can start thinking about making it a part of OMOP vocabulary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants