Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Bug Bash] The version of a deprecated package “Microsoft.NetCore.App” is empty and the “Update” button is available in Browse tab #12057

Closed
v-luzh opened this issue Aug 26, 2022 · 8 comments · Fixed by NuGet/NuGet.Client#4844
Assignees
Labels
Found:ManualTests Functionality:VisualStudioUI Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client RegressionFromPreviousRTM A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3 Triage:Investigate Type:Bug

Comments

@v-luzh
Copy link

v-luzh commented Aug 26, 2022

NuGet Product Used

Visual Studio Package Management UI

Product Version

Dev\6.4.0.51

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Details about Problem

VS Version: Main\32825.32
NuGet Version: Dev\6.4.0.51
OS Version: Windows-11-Enterprise-21H2 ENU

Detailed repro steps

  1. Create a “C# Web Driver Test for Edge (.NET Core)” project in VS.
  2. Right-Click the project in the Solution Explorer window and select ‘Manage NuGet Packages…’.
  3. Click the “Browse” tab and search package “Microsoft.NetCore.App” in the filter.
  4. Click the searched package in the list and observe the right panel.

Expected

The version of a deprecated package “Microsoft.NetCore.App” should not be empty. The “Update” button should not be available if the empty version is expected.

Actual

The version of a deprecated package “Microsoft.NetCore.App” is empty and the “Update” button is available as below screenshot.
image

Note:

It doesn’t repro on NuGet Client 5.11.2.2.

Verbose Logs

No response

@donnie-msft
Copy link
Contributor

@martinrrm could you take a look today to help understand the prioritization? What happens when clicking Update, for example?

@martinrrm
Copy link
Contributor

If you click update nothing happens, I can reproduce this bug. The problem is that Microsoft.NetCore.App doesnt have a OriginalString property and the combobox breaks. I created the application, and some packages are as package reference to the .csproj, but not this one and its being displayed as a top-level dependency.

image
image

@nkolev92
Copy link
Member

nkolev92 commented Oct 5, 2022

Is this a regression?

@martinrrm
Copy link
Contributor

I think it is, it should be like this since the combobox version was merged

@nkolev92
Copy link
Member

nkolev92 commented Oct 5, 2022

Regression during this version (6.4), or from a previous version (6.3)?

We might want to get the fix in 6.4 regardless.

@martinrrm
Copy link
Contributor

This should be present in 6.3 too

@nkolev92
Copy link
Member

nkolev92 commented Oct 5, 2022

Ok, so it was a bug in 6.3. Given the lack of reports, then maybe we don't need it patched.

@nkolev92
Copy link
Member

nkolev92 commented Oct 5, 2022

Given that this affects Maui projects, we want to take this in 6.4

@nkolev92 nkolev92 added the RegressionFromPreviousRTM A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3 label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Functionality:VisualStudioUI Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client RegressionFromPreviousRTM A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3 Triage:Investigate Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants