Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated XLA flag #1010

Merged
merged 13 commits into from
Sep 5, 2024
Merged

remove deprecated XLA flag #1010

merged 13 commits into from
Sep 5, 2024

Conversation

kocchop
Copy link
Contributor

@kocchop kocchop commented Aug 21, 2024 •
edited
Loading

  1. xla_gpu_enable_triton_gemm is still needed.
  2. Removed some other deprecated XLA flags: xla_gpu_enable_triton_softmax_fusion
  3. Also removed some XLA flags that are now turned on by default. xla_enable_async_all_gather etc.

@kocchop kocchop requested review from olupton and nouiz August 21, 2024 21:23
@kocchop kocchop marked this pull request as draft August 21, 2024 21:29
@kocchop kocchop changed the title removed deprecated XLA flag remove deprecated XLA flag Aug 21, 2024
@kocchop kocchop marked this pull request as ready for review August 21, 2024 23:09
@kocchop kocchop requested a review from terrykong August 23, 2024 01:12
olupton
olupton reviewed Aug 23, 2024
View reviewed changes
rosetta/rosetta/projects/pax/README.md Outdated Show resolved Hide resolved
.github/container/test-maxtext.sh Outdated Show resolved Hide resolved
rosetta/docs/PGLE.md Outdated Show resolved Hide resolved
@kocchop kocchop requested a review from olupton August 23, 2024 19:52
olupton
olupton previously approved these changes Aug 26, 2024
View reviewed changes
@olupton olupton dismissed terrykong’s stale review August 26, 2024 08:59

Change has been made

nouiz
nouiz reviewed Aug 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
nouiz
nouiz requested changes Aug 26, 2024
View reviewed changes
rosetta/docs/NATIVE_FP8.md Outdated Show resolved Hide resolved
rosetta/docs/PGLE.md Outdated Show resolved Hide resolved
@nouiz
Copy link
Collaborator

nouiz commented Aug 27, 2024

This PR need a rebase due to conflict.

nouiz
nouiz reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion. Lets wait for Kaixi to confirm the current upstream status. If upstream is broken, there is a new flags that we could use to trigger the old behavior.

rosetta/docs/GPU_performance.md Outdated Show resolved Hide resolved
@kocchop
Copy link
Contributor Author

kocchop commented Aug 29, 2024

One small suggestion. Lets wait for Kaixi to confirm the current upstream status. If upstream is broken, there is a new flags that we could use to trigger the old behavior.

sure, let's wait for @kaixih to get back on this

@kocchop kocchop requested a review from nouiz September 3, 2024 20:47
nouiz
nouiz requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial fix. Otherwise, I think we can merge.

rosetta/docs/PGLE.md Outdated Show resolved Hide resolved
rosetta/rosetta/projects/maxtext/scripts/example_slurm.sub Outdated Show resolved Hide resolved
@kocchop kocchop requested a review from nouiz September 4, 2024 22:10
@kocchop kocchop merged commit ecacd5b into main Sep 5, 2024
165 of 170 checks passed
@kocchop kocchop deleted the faysal/remove-deprecated-xla-flags branch September 5, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nouiz nouiz nouiz approved these changes

@terrykong terrykong Awaiting requested review from terrykong

@kaixih kaixih Awaiting requested review from kaixih

@olupton olupton Awaiting requested review from olupton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kocchop @nouiz @kaixih @olupton @terrykong