You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug description calculate_horizontal_plane, calculate_cross_plane, and calculate_y_plane use a zero yaw angles if called with yaw_angles=None. A more intuitive behavior to me is to use the existing yaw angles from self.floris.farm.yaw_angles.
To Reproduce
Run any case with non-zero yaw angles.
Call calculate_horiziontal_plane (for example) on the case, and pass the result to visualize_cut_plane.
Observe from the output that the flow corresponds to that of zero yaw angles.
Expected behavior
I would have expected to default to the existing yaw angles from self.floris.farm.yaw_angles instead.
Floris Version
3.1
System Information (please complete the following information):
OS: Windows 10
Library versions
matplotlib: 3.5.2
numpy: 1.22.3
pytest: 7.1.2
scipy: 1.8.1
The text was updated successfully, but these errors were encountered:
Bug description
calculate_horizontal_plane
,calculate_cross_plane
, andcalculate_y_plane
use a zero yaw angles if called withyaw_angles=None
. A more intuitive behavior to me is to use the existing yaw angles fromself.floris.farm.yaw_angles
.To Reproduce
calculate_horiziontal_plane
(for example) on the case, and pass the result tovisualize_cut_plane
.Expected behavior
I would have expected to default to the existing yaw angles from
self.floris.farm.yaw_angles
instead.Floris Version
3.1
System Information (please complete the following information):
The text was updated successfully, but these errors were encountered: