Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: planar calculation results use zero yaw angles by default instead of the specified simulation yaw angles #448

Open
pjireland opened this issue Jun 22, 2022 · 0 comments
Assignees
Labels
bug Something isn't working enhancement An improvement of an existing feature floris.tools
Milestone

Comments

@pjireland
Copy link
Contributor

pjireland commented Jun 22, 2022

Bug description
calculate_horizontal_plane, calculate_cross_plane, and calculate_y_plane use a zero yaw angles if called with yaw_angles=None. A more intuitive behavior to me is to use the existing yaw angles from self.floris.farm.yaw_angles.

To Reproduce

  1. Run any case with non-zero yaw angles.
  2. Call calculate_horiziontal_plane (for example) on the case, and pass the result to visualize_cut_plane.
  3. Observe from the output that the flow corresponds to that of zero yaw angles.

Expected behavior
I would have expected to default to the existing yaw angles from self.floris.farm.yaw_angles instead.

Floris Version
3.1

System Information (please complete the following information):

  • OS: Windows 10
  • Library versions
    • matplotlib: 3.5.2
    • numpy: 1.22.3
    • pytest: 7.1.2
    • scipy: 1.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement An improvement of an existing feature floris.tools
Projects
Status: Future Steps
Development

No branches or pull requests

2 participants