Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduleFile has non implemented methods such as TimeSeries #5247

Open
jmarrec opened this issue Aug 29, 2024 · 0 comments
Open

ScheduleFile has non implemented methods such as TimeSeries #5247

jmarrec opened this issue Aug 29, 2024 · 0 comments

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Aug 29, 2024

Issue overview

A bunch of public methods actually have zero implementation, and no warning whatsoever. Been like this for 6 years

Current Behavior

openstudio::TimeSeries ScheduleFile_Impl::timeSeries() const {
openstudio::TimeSeries result;
/* FIXME!
Date startDate(openstudio::MonthOfYear(this->startMonth()), this->startDay());
Time intervalLength(0, 0, this->intervalLength());
Vector values(this->numExtensibleGroups());
unsigned i = 0;
for (const ModelExtensibleGroup& group : castVector<ModelExtensibleGroup>(extensibleGroups())) {
OptionalDouble x = group.getDouble(0);
OS_ASSERT(x);
values[i] = *x;
++i;
}
TimeSeries result(startDate, intervalLength, values, "");
result.setOutOfRangeValue(this->outOfRangeValue());
*/
return result;
}

Expected Behavior

They should be removed or implemented, given that they are public

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 3.8.0, develop

Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant