Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitenvironment is broken for nnpdfcpp fits #1414

Closed
Zaharid opened this issue Sep 23, 2021 · 1 comment
Closed

Fitenvironment is broken for nnpdfcpp fits #1414

Zaharid opened this issue Sep 23, 2021 · 1 comment
Assignees

Comments

@Zaharid
Copy link
Contributor

Zaharid commented Sep 23, 2021

#1328 added code like https://github.com/NNPDF/nnpdf/blame/f2ad3ea60cec9c93b958b5ec77387d82142e8575/validphys2/src/validphys/config.py#L274 which is not valid for nnpdfcpp fits since they don't have the corresponding keys. While we have #1405 for now it would be good to be on top of what works and what doesn't (but not sure about what to do here).

@Zaharid
Copy link
Contributor Author

Zaharid commented Nov 4, 2021

Closed in #1418.

@Zaharid Zaharid closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants