Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG/updated Documentation #216

Open
Radonirinaunimi opened this issue Feb 23, 2023 · 8 comments
Open

Add CHANGELOG/updated Documentation #216

Radonirinaunimi opened this issue Feb 23, 2023 · 8 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Radonirinaunimi
Copy link
Member

Since EKO is now being used in multiple projects, would it be possible to have change logs whenever breaking changes are added in tags/releases? For the past couple of weeks, in our nnusf project, I've often found myself finding changes that break backward compatibility (see for example NNPDF/nnusf#85). Or at least the corresponding tutorials alpha_s.ipynb should be updated.

@Radonirinaunimi Radonirinaunimi added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 23, 2023
@alecandido
Copy link
Member

alecandido commented Feb 23, 2023

It has always been a nice-to-have, but never top-priority.

Essentially, doing it manually requires making all developers and reviewers responsible for the updates, making the process heavier and fallible.
And since there is not a single way to translate PRs in a change-log, I always postponed the problem for better investigation.

If you find a similar project with a good enough workflow (requiring little manual effort), I'd be glad to adopt the same strategy!

P.S.: just to give an idea, what I mean is that the title of the PR, together with date and link, can be added automatically to the CHANGELOG.md file, e.g. by a GH workflow, on PR opening pull_request: opened, to edit the file the first time, and pull_request: review_requested, to check the title is still updated, and, in case it isn't, write a comment on the PR. As you see it is perfectly doable and improvable, but requires quite some development, never had time enough

@felixhekhorn
Copy link
Contributor

the above refers to the CHANGELOG - the documentation surely has to be maintained as much as we can ...

just to mention: of course this is closely related to #145

@alecandido
Copy link
Member

the above refers to the CHANGELOG - the documentation surely has to be maintained as much as we can ...

Agreed, but we are already putting a bit of effort to maintain the docs, and contributors are more and more aware of the necessity of maintaining updated docs (I hope...). And this for sure has to be done manually.

The automated CHANGELOG proposal is just to avoid extra burden. If we have too many things to maintain manually, at some point none of them will be sufficiently important any longer...

@Radonirinaunimi
Copy link
Member Author

I fully understand that (unfortunately) in all cases some efforts will be needed. But as @alecandido alluded there might be some ways to alleviate this burden. The best one I know for example is github-changelog-generator, which also has been implemented in various github action for further ease.

@alecandido
Copy link
Member

The best one I know for example is github-changelog-generator, which also has been implemented in various github action for further ease.

Not very maintained in the last year, but sufficiently popular. It seems stable enough to fit the purpose.
Can you also point out one of these actions?

@Radonirinaunimi
Copy link
Member Author

The actions that I was alluding to are even less maintained in the past two years 🙃 But the CLI itself should do the job (or perhaps at least worth trying, as you said it is sufficiently popular 😄).

@felixhekhorn
Copy link
Contributor

The alpha_s tutorial was updated in 45682d7 - we can keep this issue for the changelog

@Radonirinaunimi
Copy link
Member Author

The alpha_s tutorial was updated in 45682d7 - we can keep this issue for the changelog

Awesome! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants