-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate data store #1100
Migrate data store #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This is a bit of a nit, but I think the flow of main
could be made a bit clearer. I would abstract the actual matching of matches (i.e. line 19 of src/bin/krillup.rs
and down) to another function. Now after parse_matches
the code goes back to the top again. Alternatively you could inline it, or leave it as-is. I don't consider it a blocking issue, but something to perhaps consider.
* Use kvx with explicit namespace type. * Do not depend on a data dir for storage. * Add support for data migration. * Add command line option to migrate data to krillup.
[draft] should probably be after #1099
This PR adds support to
krillup
to migrate data from one store to another. It seems to work both in unit test and by manual testing of the actualkrillup
binary.However, in doing this work I discovered that the (hidden) runtime that is used in the synchronous
kvx
lib will not work with Krill - as it already has a (tokio) runtime. So that will need thought, and a separate fix and PR.