Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a logo #664

Open
1 task done
vedran-kasalica opened this issue Sep 10, 2024 · 4 comments · May be fixed by #663
Open
1 task done

Make a logo #664

vedran-kasalica opened this issue Sep 10, 2024 · 4 comments · May be fixed by #663
Labels
template Related to the template itself, as opposed to the generated code

Comments

@vedran-kasalica
Copy link
Member

Checklist before submitting an issue

  • I have checked the existing issues and couldn't find an issue about this bug.

Issue details

It would be nice to make a template logo and include it in the readme. It would make the package better recognizable.
@vedran-kasalica vedran-kasalica added the template Related to the template itself, as opposed to the generated code label Sep 10, 2024
@vedran-kasalica vedran-kasalica linked a pull request Sep 10, 2024 that will close this issue
Open
@vedran-kasalica vedran-kasalica linked a pull request Sep 10, 2024 that will close this issue
adds a logo to the README #663
Open
@egpbos
Copy link
Member

egpbos commented Sep 10, 2024

Perhaps I should motivate the PR a bit better, let me give that a shot to start off the discussion.

A logo is a simple addition to make it easier and a bit nicer to communicate about the project, both externally and in for instance the RSD and all the places where the RSD information is used (reports and such). Many of our successful projects have a logo; this one is currently a bit of an odd one out. Initially I thought it would be a bit weird to have a logo on a template, since the whole point is for the template to be instantiated without branding so that the user can apply their own. That will remain the case in the generated project. For the repo's README itself, though, and places like the RSD, it adds a little flair and professionalism.

We definitely don't want to over-engineer this, so I just took 1 minute to generate something using ChatGPT that is not too eScience branded, because we also want to welcome non-NLeSC contributors, but captures the essentials: a copier, a snake and a researcher. I'm very happy Vedran cleaned up the loose ends :) Let's not tweak it any further (at least for now).

Anybody strongly against this addition?

@c-martinez
Copy link
Member

Nice idea adding a logo! Agree with the motivation (looks better on the RSD)

One small point: we should consider where we will be using the logo, and how it looks then. For example, the current version might not work great if you reduce it to the size it will be displayed on the RSD or as an favicon on your browser tab.

@egpbos
Copy link
Member

egpbos commented Sep 10, 2024

Good points! The RSD page seems to shrink the height to 144 pixels; on my screen that still works well with this logo. I don't think we need a favicon; at least I don't foresee currently us building a custom website around the template.

@egpbos egpbos mentioned this issue Sep 12, 2024
Open
@c-martinez c-martinez mentioned this issue Sep 12, 2024
Open
@egpbos
Copy link
Member

egpbos commented Sep 18, 2024

If nobody objects, let's go forward with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
template Related to the template itself, as opposed to the generated code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds a logo to the README NLeSC/python-template
3 participants
@egpbos @c-martinez @vedran-kasalica