Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Invites functionality isn't organized #103

Closed
mikemaddem opened this issue Aug 22, 2020 · 6 comments
Closed

Team Invites functionality isn't organized #103

mikemaddem opened this issue Aug 22, 2020 · 6 comments
Labels
help wanted Extra attention is needed high priority

Comments

@mikemaddem
Copy link
Member

TeamInvite objects are stored and used to track membership on a team, however it'd be much easier to just check the user exists in the teams founder fk field, captains mtm field, or the players mtm field.

Seeing as this is a rather large fix porting a site from the previous work arounds could cause issues, would like this completed sooner rather then later to avoid compatability issues.

@mikemaddem mikemaddem added help wanted Extra attention is needed high priority labels Aug 22, 2020
@mikemaddem
Copy link
Member Author

mikemaddem commented Aug 22, 2020

For now we could look into more advanced filtering.

Here are some issues that I've noticed.

On the teaminvites page it shows invites for teams that you've created.

If a user has already declined an invite to a team a new invite can't be made.

@mikemaddem
Copy link
Member Author

mikemaddem commented Aug 22, 2020

  • Match report permissions check needs to be updated

  • team invite create permissions need to be updated

  • team promotion permissions need to be updated

  • team remove player permissions need to be updated

  • tournament join permissions need to be updated.

  • TeamInviteGetForm.

  • Remove the through field of the mtm field of team.players - same for captain mtm field.

Other usages

@mikemaddem
Copy link
Member Author

mikemaddem commented Aug 27, 2020

  • Match report permissions check needs to be updated - NEEDS TESTING
  • team invite create permissions need to be updated - NEEDS TESTING
  • team promotion permissions need to be updated
  • team remove player permissions need to be updated -NEEDS TESTING
  • tournament join permissions need to be updated.
  • TeamInviteGetForm.
  • Remove the through field of the mtm field of team.players - same for captain mtm field.

Other usages

  • [x]team leave updated - NEEDS TESTING
  • dissolve team updated - NEEDS TESTING
  • match list - needs updating

@mikemaddem
Copy link
Member Author

  • Match report permissions check needs to be updated - NEEDS TESTING
  • team invite create permissions need to be updated - NEEDS TESTING
  • team promotion permissions need to be updated - unknown?
  • team remove player permissions need to be updated -NEEDS TESTING
  • tournament join permissions need to be updated.
  • TeamInviteGetForm.
  • Remove the through field of the mtm field of team.players - same for captain mtm field.

Other usages

  • [x]team leave updated - NEEDS TESTING
  • dissolve team updated - NEEDS TESTING
  • match list - NEEDS TESTING
  • Teams list
  • edit team permissions - needs testing

@mikemaddem
Copy link
Member Author

keeping this open because tournament join and team permission need to be relooked at

@mikemaddem
Copy link
Member Author

Reworked a lot of team membership functionality.
TODO:
Team dissolve
remove player
leave team

do not reflect the changes in userprofile.captain_teams or userprofile.founder_teams or userprofile.player_teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed high priority
Projects
None yet
Development

No branches or pull requests

1 participant