Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

After changing skybox to void, skybox reverts on exiting theatre mode. #2605

Closed
philip-lamb opened this issue Jan 9, 2020 · 1 comment · Fixed by #2606
Closed

After changing skybox to void, skybox reverts on exiting theatre mode. #2605

philip-lamb opened this issue Jan 9, 2020 · 1 comment · Fixed by #2606
Assignees
Labels
bug This issue is a software or functional defect P3 Backlog [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@philip-lamb
Copy link
Contributor

philip-lamb commented Jan 9, 2020

Configuration

Firefox Reality version: 8
Firefox Reality build ID: from master 34c12f5

Hardware: All supported

Steps to Reproduce

  1. Select a skybox other than void.
  2. Switch skybox to void.
  3. Enter theatre mode and then choose an immersive projection
  4. Exit immersive theatre mode.

Current Behavior

Previous non-void skybox is visible.

Expected Behavior

"void" remains selected, i.e. no skybox is visible.

Possible Solution

Currently, in BrowserWorld, if changing to "void" and a skybox has previously been loaded, the previous skybox is just hidden, rather than removed from the scene graph, making other uses of show/hide skybox produce undesired behaviour. Better to remove and delete the skybox. Fixed by #2606.

@philip-lamb philip-lamb added bug This issue is a software or functional defect P3 Backlog labels Jan 9, 2020
@philip-lamb philip-lamb added this to the #8 features milestone Jan 9, 2020
@philip-lamb philip-lamb self-assigned this Jan 9, 2020
@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 8-40101959 (3c2a71e) installed on the Oculus Go, Quest, HTC Vive Focus and Focus Plus headsets.
Now, the skybox does not revert on exiting theatre mode after a void environment is selected.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a software or functional defect P3 Backlog [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants