Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

[HTC] The "English[en]" language is wrongly set as default for the Preferred Website Language when it's Reset #2422

Closed
Softvision-RemusDranca opened this issue Dec 5, 2019 · 3 comments · Fixed by #2518
Assignees
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Notes]:

  • As a side effect as this issue the "English (United States)[en-US]" language can no longer be set as default since it appears to already be checked.

[Affected Versions]:

  • Firefox Reality version 7 RC6 (b01367a)

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • HTC Vive Focus - Android 7.1.2

[Prerequisites]:

  • The Firefox Reality browser is opened.

[Steps to reproduce]:

  1. Open the "Language" card from Settings.
  2. Click the "Edit" button for the "Display Website Language" option.
  3. Click the "Reset" button from the bottom of the card.
  4. Observe the Preferred Website Language section.

[Expected results]:

  • The "English (United States)[en-US]" language remains set as default.

[Actual results]:

  • The "English[en]" language is set as default.

[Additional Notes]:

  • This issue is reproducible if any language is set as Preferred Website Language.
  • This issue is also reproducible if the "Reset" button from the "Language" card is clicked.
  • I was not able to reproduce this issue on the Oculus devices.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added regression [QA]:Normal issue Label for QA to mark normal issues logged labels Dec 5, 2019
@jvonitter jvonitter added this to the #9 polish milestone Dec 5, 2019
@keianhzo keianhzo self-assigned this Dec 9, 2019
@keianhzo
Copy link
Contributor

keianhzo commented Dec 9, 2019

Fixed by 2bd5324

@keianhzo keianhzo closed this as completed Dec 9, 2019
@Softvision-GeluHaiduc
Copy link

I have verified that this issue with the latest Firefox Reality version 8-33472001 (6ba3881) installed on the HTC Vive Focus and Focus Plus headsets.
Unfortunately, the issue is still reproducible. I will reopen the issue.

@Softvision-RemusDranca
Copy link
Author

Based on comment from the PR the expected behavior is now the one described in this issue where the system language is set as default content language after reset. Also the "English (United States)[en-US]" language is no longer checked and can be added in the Preferred Language section.
Tested on the HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2) with the latest Firefox Reality version 8-40030225 (e6f4dda) from master.
I will mark this issue as verified-fixed.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 3, 2020
@jvonitter jvonitter modified the milestones: #9 polish, #8 features Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants