Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add unit tests for Glean #2311

Closed
daoshengmu opened this issue Nov 19, 2019 · 1 comment · Fixed by #2444
Closed

Add unit tests for Glean #2311

daoshengmu opened this issue Nov 19, 2019 · 1 comment · Fixed by #2444
Assignees
@daoshengmu
Labels
in progress task This issue is maintenance or an operational requirement telemetry
Milestone
#8 features

Comments

@daoshengmu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We have enabled Glean metrics in FxR. To avoid possible regressions on our metrics, we should consider to add unit tests.

Describe the solution you'd like
We can take Fenix's GleanMetricsServiceTest.kt as our reference.
@daoshengmu daoshengmu added task This issue is maintenance or an operational requirement telemetry labels Nov 19, 2019
@daoshengmu daoshengmu mentioned this issue Nov 19, 2019
Closed
@jvonitter jvonitter added this to the #8 features milestone Nov 20, 2019
@daoshengmu
Copy link
Contributor Author

Documents:
https://mozilla.github.io/glean/book/user/testing-metrics.html?highlight=GleanTestRule#general-test-api-method-semantics

https://mozilla.github.io/glean/book/user/pings/testing-custom-pings.html?highlight=GleanTestRule#example-testing-of-a-custom-ping

@daoshengmu daoshengmu mentioned this issue Dec 10, 2019
Merged
@daoshengmu daoshengmu self-assigned this Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@daoshengmu daoshengmu

Labels
in progress task This issue is maintenance or an operational requirement telemetry
Projects
None yet
Milestone
#8 features
Development

Successfully merging a pull request may close this issue.

Support Glean metric unit tests MozillaReality/FirefoxReality
2 participants
@daoshengmu @jvonitter