Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The FxA first-run explainer page buttons in a click sate have the same background as the page #2258

Closed
Softvision-GeluHaiduc opened this issue Nov 14, 2019 · 3 comments · Fixed by #2335
Assignees
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-GeluHaiduc
Copy link

[Affected Versions]:

  • Firefox Reality version 6 RC5 (33a031c)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The Firefox Reality browser is opened.
  • Make sure an FxA account is NOT logged in.

[Steps to reproduce]:

  1. Click the Hamburger menu and select the “Send Tab to Device” option.
  2. Using the controller click and hold the “Start Browsing” or “Sign In” button.
  3. Observe the button.

[Expected results]:

  • The background of the buttons change to a void color and the text inside change to a fog color.

[Actual results]:

  • The background of the button changes to the same color as the background of the explainer page.

[Notes]:

  • Attached a screen recording of the issue here.
@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Normal issue Label for QA to mark normal issues logged label Nov 14, 2019
@keianhzo
Copy link
Contributor

keianhzo commented Nov 14, 2019

There is a task about dialogs standarization #2131. Maybe we want to update the spec taking this into consideration. @jvonitter @thenadj

@jvonitter
Copy link
Contributor

Yep, we can look at that once Nadja and co are back from break. For now, let's just make this one match the colors for backgrouds and buttons that we usually use. See SL-7 for spec

@Softvision-GeluHaiduc
Copy link
Author

Softvision-GeluHaiduc commented Nov 25, 2019

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 7 RC3 (7b66fb1) installed on the Oculus Go, Quest, HTC Vive Focus and Focus Plus headsets.
Now, the FxA first-run explainer page buttons in a click sate have a different background color as the page.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants