Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Korean Keyboard #1235

Closed
jvonitter opened this issue May 16, 2019 · 11 comments · Fixed by #1306
Closed

Korean Keyboard #1235

jvonitter opened this issue May 16, 2019 · 11 comments · Fixed by #1306
Assignees
Labels
Final Design Design complete. Any request for design revision must open in a new issue. L10n Localization
Milestone

Comments

@jvonitter
Copy link
Contributor

Spec is here: https://trello.com/c/4MSGPrFY/198-uis-57-korean-keyboard
cc @thenadj

@jvonitter jvonitter added Final Design Design complete. Any request for design revision must open in a new issue. L10n Localization P1 Fix in the current development iteration labels May 16, 2019
@jvonitter jvonitter added this to the v1.3 milestone May 20, 2019
@MortimerGoro MortimerGoro self-assigned this Jun 4, 2019
@daoshengmu
Copy link
Contributor

@jvonitter I can't access this spec. Could I get the permission to access it via my email?

@thenadj
Copy link

thenadj commented Jun 10, 2019

@daoshengmu I just added you to the Trello board. Look for an invite in your inbox.

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Jun 11, 2019

@thenadj I found two differences in the spec. I checked both iOS/Android system keyboards and the Korean Jamo tables to confirm the final values (http://www.programminginkorean.com/programming/hangul-in-unicode/composing-syllables-in-unicode/). Here is an image with the correct keys marked:

Screenshot_20190611-121718

@MortimerGoro
Copy link
Contributor

@thenadj Also found that iOS/Mac represents the marked bottom key in a different way:
IMG_1913

But they seem to be the same. If I email or copy paste the key from iOS to Android both representations are different but it's the same key for jamo table combinatios or search results.

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Jun 11, 2019

@Pike There are some differences in the space key. We are using 공백 in Firefox Reality, but if you check space key labels on both images from Android and iOS all of them are different. Could you check with translators that 가기 is the right value? I didn't find a way to attach images in pontoon.

@MortimerGoro
Copy link
Contributor

@Pike I found that Android keyboard uses "Korean" in the space key. So the difference is between iOS and Firefox Reality, which both use "SPACE" translated to each language

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Jun 11, 2019

@Pike other difference is the label for the enter key using the "Go" action, keyboard_go_labelstrings.xml entry. Firefox Reality uses 가기 but iOS keyboard is using another string (check the text of the blue button next to the .)

@Pike
Copy link
Contributor

Pike commented Jun 11, 2019

Forwarding this to our PM @Delphine here.

@Delphine
Copy link

I'll get in touch with localizers and circle back here, thanks

@Delphine
Copy link

@cs09g, @hyeonseok: Could you please advise on this issue? thank you!

@philip-lamb philip-lamb removed the P1 Fix in the current development iteration label Jun 12, 2019
@cs09g
Copy link

cs09g commented Jun 13, 2019

The different look is caused by font. its meanings are the same.
image
(github uses left one: ㅊ, ㅎ)
for "SPACE", "간격" would be better than "공백".
for "Go", "이동" would be better than "가기".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Final Design Design complete. Any request for design revision must open in a new issue. L10n Localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants