diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/BookmarksCallback.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/BookmarksCallback.java index 17fbc5e8e..0d23a7d06 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/BookmarksCallback.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/BookmarksCallback.java @@ -13,5 +13,4 @@ default void onFxALogin(@NonNull View view) {} default void onFxASynSettings(@NonNull View view) {} default void onShowContextMenu(@NonNull View view, Bookmark item, boolean isLastVisibleItem) {} default void onHideContextMenu(@NonNull View view) {} - default void onItemClicked(@NonNull View view, Bookmark item) {} } diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/HistoryCallback.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/HistoryCallback.java index badf60e38..5070d582a 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/HistoryCallback.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/HistoryCallback.java @@ -13,5 +13,4 @@ default void onFxALogin(@NonNull View view) {} default void onFxASynSettings(@NonNull View view) {} default void onShowContextMenu(@NonNull View view, @NonNull VisitInfo item, boolean isLastVisibleItem) {} default void onHideContextMenu(@NonNull View view) {} - default void onItemClicked(@NonNull View view, VisitInfo item) {} } diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/BookmarksView.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/BookmarksView.java index 7f9241325..dcb02d9b0 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/BookmarksView.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/BookmarksView.java @@ -155,8 +155,6 @@ public void onClick(@NonNull View view, @NonNull Bookmark item) { Session session = SessionStore.get().getActiveSession(); session.loadUri(item.getUrl()); - - mBookmarksViewListeners.forEach((listener) -> listener.onItemClicked(view, item)); } @Override diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/HistoryView.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/HistoryView.java index 4f644d2b7..e96d694ea 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/HistoryView.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/HistoryView.java @@ -158,8 +158,6 @@ public void onClick(View view, VisitInfo item) { Session session = SessionStore.get().getActiveSession(); session.loadUri(item.getUrl()); - - mHistoryViewListeners.forEach((listener) -> listener.onItemClicked(view, item)); } @Override diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java index 9746e9a5b..4294cd5e1 100644 --- a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java +++ b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java @@ -27,6 +27,7 @@ import androidx.annotation.UiThread; import org.jetbrains.annotations.NotNull; +import org.mozilla.geckoview.AllowOrDeny; import org.mozilla.geckoview.GeckoResult; import org.mozilla.geckoview.GeckoSession; import org.mozilla.geckoview.PanZoomController; @@ -67,7 +68,6 @@ import java.util.GregorianCalendar; import java.util.concurrent.CopyOnWriteArrayList; import java.util.concurrent.Executor; -import java.util.function.Consumer; import mozilla.components.concept.storage.PageObservation; import mozilla.components.concept.storage.PageVisit; @@ -1423,11 +1423,6 @@ public void onFxASynSettings(@NonNull View view) { public void onHideContextMenu(@NonNull View view) { hideContextMenus(); } - - @Override - public void onItemClicked(@NonNull View view, Bookmark item) { - hideBookmarks(); - } }; private HistoryCallback mHistoryListener = new HistoryCallback() { @@ -1457,11 +1452,6 @@ public void onFxASynSettings(@NonNull View view) { public void onHideContextMenu(@NonNull View view) { hideContextMenus(); } - - @Override - public void onItemClicked(@NonNull View view, VisitInfo item) { - hideHistory(); - } }; private void hideContextMenus() { @@ -1573,6 +1563,22 @@ public void captureImage() { mSession.captureBitmap(); } + // GeckoSession.NavigationDelegate + + @Nullable + @Override + public GeckoResult onLoadRequest(@NonNull GeckoSession geckoSession, @NonNull LoadRequest loadRequest) { + if (isHistoryVisible()) { + hideHistory(); + } + + if (isBookmarksVisible()) { + hideBookmarks(); + } + + return GeckoResult.ALLOW; + } + @Override public void onLocationChange(@NonNull GeckoSession session, @Nullable String url) { updateTitleBarUrl(url);