Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect main field in npm package #105

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

robinnorth
Copy link
Collaborator

No description provided.

@robinnorth robinnorth force-pushed the robinnorth-patch-2 branch 2 times, most recently from f212112 to b7f57d1 Compare January 18, 2018 19:36
@BehindTheMath
Copy link
Collaborator

This was actually on my to do list.

However, I think the main field should point to index.js. If I'm not mistaken, only Node uses the main field, to determine the entry point of the module. Anyone requireing this package in Node is doing the bundling themselves, so we might as well serve the source itself without the Browserify wrapper code. Someone who is using the library in a broswer in a script tag (using unpkg.com) will link to pjax.js directly.

@robinnorth
Copy link
Collaborator Author

You are indeed right, it really should be the other way around. Clearly it used to point to the built library file, but it does make more sense to point at the source. I'll amend my PR for you.

@BehindTheMath BehindTheMath merged commit ca61c4a into MoOx:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants