Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blur on active element when page is changed #4

Closed
MoOx opened this issue Apr 22, 2014 · 4 comments
Closed

Add blur on active element when page is changed #4

MoOx opened this issue Apr 22, 2014 · 4 comments
Assignees
@MoOx
Labels
bug
Milestone
0.2.5

Comments

@MoOx
Copy link
Owner

MoOx commented Apr 22, 2014

To remove focus on a clicked/tapped link (eg on ipad, a attached tooltip can remain visible after the new page load, which is weird)
@MoOx MoOx self-assigned this Apr 22, 2014
@MoOx
Copy link
Owner Author

MoOx commented Apr 23, 2014

Be careful to this issue defunkt/jquery-pjax#377

@MoOx MoOx assigned MoOx and unassigned MoOx Aug 13, 2014
@BehindTheMath
Copy link
Collaborator

Add blur on active element when page is changed
To remove focus on a clicked/tapped link (eg on ipad, a attached tooltip can remain visible after the new page load, which is weird)

@MoOx Isn't this covered by this line and this line? I don't know why both are needed, but regardless, the focus should be lost.

Be careful to this issue defunkt/jquery-pjax#377

This should be a simple fix, similar to what was ultimately implemented here.

@BehindTheMath BehindTheMath added this to the 0.2.5 milestone Jan 24, 2018
@MoOx
Copy link
Owner Author

MoOx commented Jan 24, 2018

You pointed the same line, but I guess you are right. Maybe I was referring to event triggered by js (eg: tooltip opened on a tap/click that should be hidden when tapping outside), can't remember...

@BehindTheMath
Copy link
Collaborator

Sorry. I meant this line and this line.

BehindTheMath added a commit that referenced this issue Jan 25, 2018
@BehindTheMath
Only blur element if it's contained by one of the selectors
fa05e94 
Previously, Pjax would blur (remove focus) from the active element
regardless of where it was on the page. This restricts that to
happen only if the active element is contained by one of the
elements represented by options.selectors, because only those are
affected by Pjax.

Fixes #4
@BehindTheMath BehindTheMath mentioned this issue Jan 25, 2018
Merged
robinnorth added a commit that referenced this issue Jan 29, 2018
@robinnorth
Merge pull request #116 from MoOx/fix/blur
20e9879 
Fix element blurring (removing focus). Closes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoOx MoOx

Labels
bug
Projects
None yet
Milestone
0.2.5
Development

No branches or pull requests
2 participants
@MoOx @BehindTheMath