User command memo, better GraphQL docstring #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
approved these changes
Dec 16, 2020
psteckler
added
ci-build-me
|
@psteckler what are the trailing bytes after the empty byte padding? The example is sending a memo of "Decode this memo" with the encoded version coming from GraphQL: import base58check
print(base58check.b58decode('E4YtexMwhedqfiQUQ2bEzNEryhuqSF3itfN8U3vAt6FTFCimnHP6Q'))Returns: |
|
Ignore that it's "Four bytes (32 bits) of SHA256-based error checking code.". Just realized I've been using base58 decoding and not base58Check decoding 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better docstring for user command memos returned by GraphQL queries.
Also cleaned up a couple of other docstrings.
Closes #6915.