Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement snarky backend with TS bigints #13966

Merged
merged 11 commits into from
Oct 3, 2023

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Aug 25, 2023

Companion of o1-labs/o1js#1092

This PR is just bumping the submodules, plus one trivial change which happened to have a large impact on witness generation performance

Note: this is targeting the snarkyjs-main branch to avoid multi-PR gymnastics for a tiny change. The intention is to merge this into develop when a few changes have accumulated - so please review as if it would go into develop. (For CI results, see the o1js repo)

@mitschabaude mitschabaude changed the base branch from snarkyjs-main to rampup September 1, 2023 07:11
@mitschabaude mitschabaude changed the base branch from rampup to snarkyjs-main September 1, 2023 07:11
@mitschabaude mitschabaude marked this pull request as ready for review September 6, 2023 13:38
@mitschabaude mitschabaude requested review from a team as code owners September 6, 2023 13:38
@mitschabaude mitschabaude requested a review from a team as a code owner October 3, 2023 15:54
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see efficiency nit in the snarky PR

@mrmr1993
Copy link
Member

mrmr1993 commented Oct 3, 2023

!ci-build-me

@mitschabaude mitschabaude requested a review from a team as a code owner October 3, 2023 19:19
@mitschabaude
Copy link
Member Author

!ci-build-me

@mitschabaude mitschabaude merged commit 5a4bd4a into snarkyjs-main Oct 3, 2023
37 of 49 checks passed
@mitschabaude mitschabaude deleted the perf/bigint-backend branch October 3, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants