This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Allow HTTP scheme for localhost URLs #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my experience, localhost URLs are almost exclusively used for development purposes, and setting up HTTPS for localhost URLs is really tedious, and most of the time unnecessary.
|
|
|
SGTM, thanks for the add! I personally work in a setup that does care about the difference, but I agree that in the majority of cases, this is fine. If you could send another PR for the examples removal that'd be great! I can if you don't have the time. |
No worries, done in #449, thanks for reaching out! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience, localhost URLs are almost exclusively used for development purposes, and setting up HTTPS for localhost URLs is really tedious, and most of the time unnecessary.
Note that I'm not completely sure of the syntax, so let me know if I'm wrong! The
:at the end is on purpose to make sure all ports are allowed. I don't think it's worth the effort to allowhttp://localhost/without a port specifically, but let me know.(On an unrelated note, I suggest removing
http://examples.com, it seems like a semi-real domain, and it's not part of https://en.wikipedia.org/wiki/Example.com / https://tools.ietf.org/html/rfc2606#section-3)