Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

misnamed-import warning for import A from '../..' #594

Closed
JoshuaKGoldberg opened this issue Oct 27, 2018 · 1 comment
Closed

misnamed-import warning for import A from '../..' #594

JoshuaKGoldberg opened this issue Oct 27, 2018 · 1 comment
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Milestone
6.0.0-beta

Comments

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Oct 27, 2018 •
edited
Loading

Similar to #378 - the fix in #591 works for '.' and similar, but not large paths such as ../../...

Perhaps we should just check if the path consists only of . and /?

As noted by @sindresorhus - thanks!
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Status: Accepting PRs Good First Issue 🙌 Howdy, neighbor! Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Hacktoberfest labels Oct 27, 2018
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 27, 2018
Merged
@Igorbek
Copy link
Contributor

Igorbek commented Oct 27, 2018 •
edited
Loading

It should be working with this path too.

Igorbek added a commit to Igorbek/tslint-microsoft-contrib that referenced this issue Oct 27, 2018
@Igorbek
Add more test cases for microsoft#378 (fixes microsoft#594)
0cacb42
@Igorbek Igorbek mentioned this issue Oct 27, 2018
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Oct 27, 2018
@Igorbek
[import-name] Fix #594 (#595)
4fa09c7 
* [import-name] Fix #378
- ignore dotted paths `.`, `..`

* Add more test cases for #378 (fixes #594)

* more tests
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Projects
None yet
Milestone
6.0.0-beta
Development

No branches or pull requests
2 participants
@Igorbek @JoshuaKGoldberg