Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Move rules off of ErrorTolerantWalker #568

Closed
JoshuaKGoldberg opened this issue Oct 15, 2018 · 0 comments
Closed

Move rules off of ErrorTolerantWalker #568

JoshuaKGoldberg opened this issue Oct 15, 2018 · 0 comments
Labels
Difficulty: Hard Only someone with heavy experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs
Milestone
6.0.0-beta

Comments

@JoshuaKGoldberg
Copy link

New rules are coming in using it... but we should really be moving to TSLint's applyWithFunction + function walk approach. RuleWalker-based rules are slow and should be avoided.

Sibling to #556.
@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Hard Only someone with heavy experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. labels Oct 15, 2018
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 24, 2018
Merged
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Hard Only someone with heavy experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs
Projects
None yet
Milestone
6.0.0-beta
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg