Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Use TypeScript's --strict mode in source code #461

Closed
JoshuaKGoldberg opened this issue Jul 20, 2018 · 0 comments
Closed

Use TypeScript's --strict mode in source code #461

JoshuaKGoldberg opened this issue Jul 20, 2018 · 0 comments
Labels
Difficulty: Hard Only someone with heavy experience in TSLint should be able to send a pull request for this issue. Domain: Code Style Rules or repository tasks related to how to style code. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs Type: Task Miscellaneous work.
Milestone
6.0.0-beta

Comments

@JoshuaKGoldberg
Copy link

https://www.typescriptlang.org/docs/handbook/compiler-options.html

It'd be nice for our source code to use TypeScript >=2's --strict options, particularly ---strictNullChecks.
@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Hard Only someone with heavy experience in TSLint should be able to send a pull request for this issue. Type: Task Miscellaneous work. Domain: Code Style Rules or repository tasks related to how to style code. Domain: Tooling Repository tasks around improving source tooling. labels Jul 20, 2018
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 31, 2018
Closed
JoshuaKGoldberg pushed a commit that referenced this issue Aug 13, 2018
Enabled TS strict mode
37013d0 
It felt right to upgrade TypeScript and TSLint to the latest versions for this.

Fixes #461
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 13, 2018
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Aug 27, 2018
Enabled TS strict mode (#492)
daacae9 
* Enabled TS strict mode

It felt right to upgrade TypeScript and TSLint to the latest versions for this.

Fixes #461

* Updated package-lock.json to latest; ran npm audit fix
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Hard Only someone with heavy experience in TSLint should be able to send a pull request for this issue. Domain: Code Style Rules or repository tasks related to how to style code. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs Type: Task Miscellaneous work.
Projects
None yet
Milestone
6.0.0-beta
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg