Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

react-a11y-anchors where link text differs by case & whitespace #394

Closed
flipchart opened this issue Sep 18, 2017 · 2 comments
Closed

react-a11y-anchors where link text differs by case & whitespace #394

flipchart opened this issue Sep 18, 2017 · 2 comments
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Accessibility Rules around accessibility verification, commonly react-a11y-*. Status: Accepting PRs Type: Rule Feature Adding a feature to an existing rule.
Milestone
6.0.0-beta

Comments

@flipchart
Copy link

The rule "Links with the same HREF should have the same link text." in react-a11y-anchors is triggered when the links differ by case, as well as due to irrelevant white space (i.e. indentation). Could this be relaxed to allow differences in case, and to ignore leading and trailing whitespace?
@JoshuaKGoldberg
Copy link

SGTM. Ideally those could be separate options, individually trigger-able.

@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Type: Rule Feature Adding a feature to an existing rule. Domain: Accessibility Rules around accessibility verification, commonly react-a11y-*. labels Jul 4, 2018
@nadyafebi
Copy link
Contributor

I'd like to take a shot on this issue if no one is working on it yet 😃

@nadyafebi nadyafebi mentioned this issue Oct 6, 2018
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Oct 7, 2018
@nadyafebi
Fix #394: Add ignore-case and ignore-whitespace options to react-a11y…
76d0853 
…-anchors (#524)

* Add ignore-case and ignore-whitespace options to react-a11y-anchors

* Add unit tests for react-a11y-anchor new options

* Add documentation for react-a11y-anchor new options

* Add new unit tests with no options enabled for react-a11y-anchors

* Update ignore-whitespace to allow trim or all whitespace

* Add and update ignore-whitespace unit tests

* Update ignore-whitespace documentation
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Accessibility Rules around accessibility verification, commonly react-a11y-*. Status: Accepting PRs Type: Rule Feature Adding a feature to an existing rule.
Projects
None yet
Milestone
6.0.0-beta
Development

No branches or pull requests
3 participants
@flipchart @JoshuaKGoldberg @nadyafebi