This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add 'typescript' to peer dependencies #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by tslint 5.1.
|
@rogierschouten we don't actually test the project on all those typescript versions and point releases are often not backwards compatible at the AST level. But it is no different than not declaring a dependency, I suppose. Can we just declare anything below 3.0 as the dependency? It is simpler in the dependency declaration and is more future safe. Do you see an issue with that? |
|
@HamletDRC that's fine I think, although this may lose some -dev versions I guess. I've changed it both for TypeScript and TSLint. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most files import "typescript" but typescript isn't depended on in package.json. You usually don't notice because typescript is installed by other modules (e.g. tslint), but it isn't proper.
Like tslint, I put typescript in the peerDependencies and I used the version range that tslint 5.1 also has in its peerDepdenencies for typescript.