This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add support for tslint version to 5.1.0 #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed in favor of TSLint's 'no-sparse-arrays' rule:
http://palantir.github.io/tslint/rules/no-sparse-arrays
* 'no-cookies' now explicitly require type checking (extends
Lint.Rules.TypedRule)
* The following rules now optionally require type checking (extend
from Lint.Rules.OptionallyTypedRule):
* no-string-based-set-immediate
* no-string-based-set-interval
* no-string-based-set-timeout
* 'no-single-line-block-comment' no longer supports nested single
line comments
* Removed 'no-unused-imports' in favor of the TSLint implementation
* The default severity for TSLint is now error; fixing easy violations that
were exposed by that change
* Add extended metadata for new rules provided by TSLint
HamletDRC
reviewed
May 5, 2017
| @@ -27,7 +27,7 @@ export class Rule extends Lint.Rules.AbstractRule { | |||
| public static FAILURE_STRING_FACTORY(initializer: string, expression: string): string { | |||
| //tslint:disable-next-line:max-line-length | |||
| return `Do not use the 'for in' statement: 'for (${initializer} in ${expression})'. If this is an object, use 'Object.keys' instead. If this is an array use a standard 'for' loop instead.`; | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
I see that tslint still has a bug in their unnecessary-semicolon rule
HamletDRC
reviewed
May 5, 2017
| @@ -46,9 +46,8 @@ class NoInvalidRegexpRuleWalker extends ErrorTolerantWalker { | |||
| if (arg1.kind === ts.SyntaxKind.StringLiteral) { | |||
| const regexpText: string = (<ts.StringLiteral>arg1).text; | |||
| try { | |||
| /* tslint:disable:no-unused-new */ | |||
| // tslint:disable-next-line:no-unused-expression | |||
HamletDRC
changed the title
|
This all looks good and I ran it on MSE and there were no issues or false positives (however, we are not doing "full program" scanning) |
|
If I upgrade to TypeScript 2.3 then some tests fail though :( |
|
Pushed and closed! |
|
@HamletDRC Could you please publish 5.0.0 to npm? |
|
@sapegin I started the process now, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #354
Lint.Rules.TypedRule)
from Lint.Rules.OptionallyTypedRule):
line comments
were exposed by that change