Fix crash on non MobileCenter push notifications #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #651 +/- ##
===========================================
- Coverage 93.12% 93.12% -0.01%
===========================================
Files 207 207
Lines 14585 14588 +3
Branches 845 847 +2
===========================================
+ Hits 13583 13585 +2
- Misses 999 1000 +1
Partials 3 3
Continue to review full report at Codecov.
|
iamclement
approved these changes
Jun 30, 2017
| @@ -194,7 +194,10 @@ - (void)didFailToRegisterForRemoteNotificationsWithError:(NSError *)error { | |||
|
|
|||
| - (BOOL)didReceiveRemoteNotification:(NSDictionary *)userInfo { | |||
| MSLogVerbose([MSPush logTag], @"User info for notification has forwarded to Push: %@", [userInfo description]); | |||
| NSDictionary *alert = [[userInfo objectForKey:kMSPushNotificationApsKey] objectForKey:kMSPushNotificationAlertKey]; | |||
| NSObject *alert = [[userInfo objectForKey:kMSPushNotificationApsKey] objectForKey:kMSPushNotificationAlertKey]; | |||
There was a problem hiding this comment.
why is the variable called "alert" if it is a NSDictionary?
There was a problem hiding this comment.
alert is key for this object in parent dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.