Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Telemetry Support for Luis Recognizer #1424

Merged
merged 4 commits into from
Mar 17, 2019
Merged

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Mar 7, 2019

Adds support for IBotTelemetryClient (no new dependencies) within the Luis Recognizer.

https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md#telemetry-support-luis

  • Properties can be added to the telemetry event per invocation
  • Class can be derived to override default behavior
  • Exposed methods to help populate events when deriving

@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2019

Pull Request Test Coverage Report for Build 51480

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 74.866%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs 3 66.67%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizer.cs 42 71.52%
Totals Coverage Status
Change from base Build 50252: 0.3%
Covered Lines: 4188
Relevant Lines: 5594

💛 - Coveralls

/// </summary>
public static class LuisTelemetryConstants
{
public const string LuisResult = "LuisResult"; // Event name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could these be static readonly? (i.e. do you ever use then in a switch-case statement?)

@daveta
Copy link
Contributor Author

daveta commented Mar 13, 2019

Thanks @johnataylor!
@ryanlengel mentioned some impending requests from customers - waiting until he gets back today to see what those are..

@ryanisgrig
Copy link
Contributor

@daveta I added comments to #1430 - they are related to the LUIS recognizer but the changes necessary are in QnA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants