Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JsCreatePromise to JsRT #2594

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

kfarnung
Copy link
Contributor

Retargeted the change to release/2.0

@kfarnung
Copy link
Contributor Author

I figured out how to rebase #2581, closing this one.

Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

*resolve = nullptr;
*reject = nullptr;

Js::JavascriptPromiseResolveOrRejectFunction *jsResolve;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: initialize this values with nullptr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed it, but I'll fix it. I assume I should do the second one as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #2595

@chakrabot chakrabot merged commit 1a7ab6c into chakra-core:release/2.0 Feb 24, 2017
chakrabot pushed a commit that referenced this pull request Feb 24, 2017
Merge pull request #2594 from kfarnung:jsrtpromise2.0
@kfarnung kfarnung deleted the jsrtpromise2.0 branch February 24, 2017 19:50
chakrabot pushed a commit that referenced this pull request Feb 25, 2017
Merge pull request #2594 from kfarnung:jsrtpromise2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants