Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when creating a branch for a non-initial release for a monorepo with independent versions #43

Closed
mcmire opened this issue Oct 14, 2022 · 0 comments · Fixed by #50
Closed

Comments

@mcmire
Copy link
Contributor

mcmire commented Oct 14, 2022

If you attempt to use create-release-branch after having used it already to release an monorepo with independent versions, you will get:

➤  ts-node ../../metamask/create-release-branch/src/cli.ts
Project appears to have workspaces. Following monorepo workflow.
Release spec already exists. Picking back up from previous run.
AssertionError [ERR_ASSERTION]: Most recent tag should start with v
    at getMostRecentTag (/Users/<username>/code/metamask/create-release-branch/node_modules/@metamask/auto-changelog/src/update-changelog.ts:19:10)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async updateChangelog (/Users/<username>/code/metamask/create-release-branch/node_modules/@metamask/auto-changelog/src/update-changelog.ts:149:25)
    at async updatePackageChangelog (/Users/<username>/code/metamask/create-release-branch/src/package.ts:268:31)
    at async updatePackage (/Users/<username>/code/metamask/create-release-branch/src/package.ts:318:5)
    at async /Users/<username>/code/metamask/create-release-branch/src/release-plan.ts:128:7
    at async Promise.all (index 1)
    at async executeReleasePlan (/Users/<username>/code/metamask/create-release-branch/src/release-plan.ts:123:3)
    at async followMonorepoWorkflow (/Users/<username>/code/metamask/create-release-branch/src/monorepo-workflow-operations.ts:117:3)
    at async main (/Users/<username>/code/metamask/create-release-branch/src/main.ts:35:5) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: '@',
  expected: 'v',
  operator: 'strictEqual'
}

See: MetaMask/auto-changelog#116

@mcmire mcmire changed the title Bug when creating a non-first release for a monorepo with independent versions Bug when creating a branch for a non-initial release for a monorepo with independent versions Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant