Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the detection of Visual Studio 2022 #771

Closed

Conversation

Xav83
Copy link

@Xav83 Xav83 commented Jun 8, 2024

Hi @McMartin,

I hope everything is going fine for you ! 🙂

I have created this Pull Request after experiencing the error message from Reprojucer.cmake, at the line 2294, on Azure Pipelines, last week, after they did update the version of Visual Studio Community used on their Visual Studio 2022 image.

After a little of debugging, I noticed that MSVC_VERSION variable is now over the version 1940.

I also found this article from Microsoft blog, named MSVC Toolset Minor Version Number 14.40 in VS 2022 v17.10, that specified that:

‘4x’ is a digit 40-49, where the ‘x’ value will continue to increase in future Visual Studio releases, starting with ‘40’ in VS 2022 v17.10.

With that information, I have created this Pull Request, so that everyone who want or have to switch to a newer version of Visual Studio will be able to enjoy FRUT. 😉

If you need any more information, or tests to be done, feel free to ask. 🙂

@MartyLake
Copy link
Collaborator

LGMT!

@McMartin McMartin force-pushed the fix-msvc-version-for-visual-studio-2022 branch from e846eee to a4d0a9c Compare September 20, 2024 11:20
@McMartin
Copy link
Owner

McMartin commented Sep 20, 2024

Hi @Xav83,
Sorry for the very late reply 😅 Thank you very much for the contribution!
Unfortunately, some node configurations have been removed from Azure Pipelines, so I'll have to first fix that before we can merge this PR. I'll work on that as soon as I can.

@McMartin McMartin force-pushed the fix-msvc-version-for-visual-studio-2022 branch from a4d0a9c to e846eee Compare September 20, 2024 11:57
@McMartin
Copy link
Owner

@Xav83 In order to get a green build on #775, I had to fix the detection of VS2022, so #775 supersedes this PR. Thank you again for opening it and making me aware of the issue!

@McMartin McMartin closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants