Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow external SpeedTest data #558

Closed
micalm opened this issue Jan 28, 2023 · 4 comments
Closed

[Feature] Allow external SpeedTest data #558

micalm opened this issue Jan 28, 2023 · 4 comments

Comments

@micalm
Copy link

micalm commented Jan 28, 2023

Description of the feature

Some people (like me) are already running external speedtests for stuff like Prometheus. Would it be possible to use something like DASHDOT_SPEED_FILE=/path/to/file.json to read these results instead of running a separate binary and test, wasting network resources?

It would also solve the issue for people who don't want to run speed tests at all while providing a scale for the network graph (#288). The file would be static then.

Obviously the JSON is only a suggestion, could very well be csv/tsv or anything else - up to external scripts to provide the data in dashdot-readable format.

Additional context

No response

@micalm micalm changed the title [Feature] Allow external SpeedTest data? [Feature] Allow external SpeedTest data Jan 28, 2023
@MauriceNino
Copy link
Owner

That's a great idea, thanks for that! Did I understand that correctly - the file can be generated in any format, so it's up to me to provide a good format? Or is there a universal format already given?

@micalm
Copy link
Author

micalm commented Jan 28, 2023

I don't think there is a standard (not 100% sure), so it's up to you to specify it. IMO basing it on Ooklas json would be fine.

@MauriceNino
Copy link
Owner

I just implemented this, and it will go live in ~2h. You can check out the docs here, once it's released. Hope this fits your needs!

MauriceNino added a commit that referenced this issue Jan 29, 2023
# [4.8.0](v4.7.0...v4.8.0) (2023-01-29)

### Features

* add option to read speed-test result from file ([006dd6f](006dd6f)), closes [#558](#558)
@MauriceNino
Copy link
Owner

🎉 This issue has been resolved in version 4.8.0

Please check the changelog for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants