Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Tagging component for selecting just a single tag #112

Open
skateman opened this issue May 10, 2019 · 5 comments
Open

Tagging component for selecting just a single tag #112

skateman opened this issue May 10, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@skateman
Copy link
Member

The current version of the tagging component was designed for assigning multiple tags to a single entity. We can't prevent adding multiple tags and even if we would have it, it does not feel right to use this kind of layout to just add a single tag.

However, we have at least one screen where we support this use case. I know that the area is being currently redesigned, however, I assume we will need some kind of tagging there anyway.

@PanSpagetka @terezanovotna can you please look into this when you have time? Also feel free to close it if you think I'm wrong.

@terezanovotna
Copy link

when we have a use case of having a tag with just single entity, it should be possibele to apply a tag with just one entity

@skateman
Copy link
Member Author

@PanSpagetka can you adjust your tagging component accordingly?

@chessbyte chessbyte added the bug Something isn't working label Feb 21, 2020
@h-kataria
Copy link
Contributor

@skateman for the cases where we only allow single tag to be assigned, shouldn't we use the drop down instead of using the tagging tree just like we did in ManageIQ/manageiq-ui-classic#5535 , or you think we still need to adjust the tagging component for those use cases?

@skateman
Copy link
Member Author

@h-kataria if you look at the comments below the PR you linked, you will understand how unpopular this idea was. If we have a tagging component, we should use it for all the cases with tags. Of course this component is IMO a little over-engineered, so it would need a little cleanup first.

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@miq-bot miq-bot added the stale label Jun 11, 2020
@Fryguy Fryguy removed the stale label Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants