From 75bef5eb54c17d01d8519090d1121e210e3976e9 Mon Sep 17 00:00:00 2001 From: Joe Rafaniello Date: Tue, 24 Sep 2024 14:09:08 -0400 Subject: [PATCH 1/2] TEST_RAILS_VERSION wasn't set in ENV so matrix was broken Rails 7.2 will not install in versions of ruby less than 3.1. Because we weren't setting the ENV variable properly, the test matrix was not correctly testing against the correct rails version and passing. --- .github/workflows/ci.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 091b8007..a909d16c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,13 +12,18 @@ jobs: strategy: matrix: ruby-version: - - '3.0' - '3.1' rails-version: - '7.0' - '7.1' - '7.2' + include: + - ruby-version: '3.0' + rails-version: '7.0' + - ruby-version: '3.0' + rails-version: '7.1' env: + TEST_RAILS_VERSION: ${{ matrix.rails-version }} CC_TEST_REPORTER_ID: "${{ secrets.CC_TEST_REPORTER_ID }}" steps: - uses: actions/checkout@v4 From f255dd2b2cfbdab40d9f8d7738e86774c9ed82ae Mon Sep 17 00:00:00 2001 From: Joe Rafaniello Date: Tue, 24 Sep 2024 14:12:33 -0400 Subject: [PATCH 2/2] Add ruby 3.2 and 3.3 to the matrix for fun --- .github/workflows/ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a909d16c..f1bc4e34 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -13,6 +13,8 @@ jobs: matrix: ruby-version: - '3.1' + - '3.2' + - '3.3' rails-version: - '7.0' - '7.1'