Restored compatibility with ESP8266 Arduino Core < 3.0.1 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makuna
approved these changes
Jul 23, 2021
AMoo-Miki
pushed a commit
to AMoo-Miki/NeoPixelBus
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#486 broke compatibility with all ESP8266 Arduino core versions but the most recent 3.0.1 one. Support for the latest version is of course the most important, still more compatibility is nice as long as it doesn't cause extra maintainance.
Version 3.0.1 added the macro
ARDUINO_ESP8266_MAJORincores/esp8266/core_version.h(esp8266/Arduino#8126), so it can be used to distinguish 3.0.1 and future releases that need to includecore_esp8266_i2s.hfrom previous versions that need to includei2s.h.Verified working in Arduino Core 2.7.4, 3.0.0 and 3.0.1.