Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2s.h conflict change #486

Merged
merged 1 commit into from
Jun 14, 2021
Merged

i2s.h conflict change #486

merged 1 commit into from
Jun 14, 2021

Conversation

Makuna
Copy link
Owner

@Makuna Makuna commented Jun 14, 2021

ESP8266 Arduino v3.1 will remove the i2s.h due to name conflict when used on case insensitive file systems.

ESP8266 Arduino v3.1 will remove the i2s.h due to name conflict when used on case insensitive file systems.
@Makuna Makuna merged commit 36b44f6 into master Jun 14, 2021
@Makuna Makuna deleted the Esp8266I2sV31 branch June 14, 2021 17:22
@agners
Copy link
Contributor

agners commented Jun 16, 2021

This does break build with 2.7.4. I am not sure what the policiy is, is NeoPixelBus only meant to support latest Arduino SDK versions?

If we'd like to keep 2.7.4 support around, we could add a ifdef ARDUINO_ESP8266_RELEASE_2_7_4, not particular pretty, but would work.

@Makuna
Copy link
Owner Author

Makuna commented Jun 16, 2021

@agners Officially I only support the latest at the time a release is made of my library. It would take FAR too much effort for a single person who isn't paid to do anything more.

All previous releases of the library are still available, you can just pick the specific release you want. You won't get the latest features and fixes though.

AMoo-Miki pushed a commit to AMoo-Miki/NeoPixelBus that referenced this pull request Aug 15, 2022
ESP8266 Arduino v3.1 will remove the i2s.h due to name conflict when used on case insensitive file systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants