Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alteration to mark Windows specifics as Obsolete #250

Merged
merged 3 commits into from
May 24, 2022
Merged

Alteration to mark Windows specifics as Obsolete #250

merged 3 commits into from
May 24, 2022

Conversation

jamesmcroft
Copy link
Member

Changes have been made to split out the non-platform specific logic from the BooleanToStringValueConverter and mark the Windows specific components as Obsolete in favor of the MADE.UI alternative.

PR checklist

  • Samples have been added/updated (where applicable)
  • Tests have been added/updated (where applicable) and pass
  • Documentation has been added/updated for changes
  • Code styling has been met on new source file changes
  • Contains NO breaking changes

Other information

@jamesmcroft jamesmcroft requested a review from a team as a code owner May 23, 2022 07:49
@tom-made tom-made merged commit 3f879e1 into main May 24, 2022
@tom-made tom-made deleted the features/new-converters branch May 24, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-made tom-made tom-made approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmcroft @tom-made