Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion box for injustices #1

Open
EpicOrange opened this issue Aug 9, 2023 · 19 comments
Open

Suggestion box for injustices #1

EpicOrange opened this issue Aug 9, 2023 · 19 comments

Comments

@EpicOrange
Copy link
Contributor

EpicOrange commented Aug 9, 2023

Experienced injustice but this bot didn't detect it? Send us the log link and describe the injustice, and it will be done

@peter1357908
Copy link
Member

peter1357908 commented Aug 15, 2023

  • Injustice idea: "you got dama'd on". Requires adding a "closed hand" flag.

Example: 5-hand-all-dama tonpuu injustice: https://tenhou.net/0/?log=2023081419gm-00c1-0000-40aab38f&tw=3

@peter1357908
Copy link
Member

peter1357908 commented Aug 19, 2023

  • "Almost got nagashimangan but":
  • somehow didn't get to make the last discard (even if you had more terminals/honors)
  • dealt in on the last tile
  • last tile got called (but it's not a ron)

@peter1357908
Copy link
Member

peter1357908 commented Aug 19, 2023

  • Got head bumped
  • Oyakaburi when tsumo hand is baiman+

@peter1357908
Copy link
Member

peter1357908 commented Aug 20, 2023

  • deal in on the tile to reach tenpai
  • deal in on the last draw that would secure tenpai payments (not necessarily haitei)

@peter1357908
Copy link
Member

peter1357908 commented Aug 20, 2023

  • you just changed your wait but the very next draw would've won your previous hand
  • advanced: you were tenpai for some tile and you changed your wait/folded but a future draw/discard would've won you the hand

@peter1357908
Copy link
Member

peter1357908 commented Aug 21, 2023

  • You were yakuman tenpai, didn't win, and would've won with a tsumo later had the game continued

@peter1357908
Copy link
Member

peter1357908 commented Aug 21, 2023

  • Your riichi discard passed but someone won before your next draw, robbing you of your stick ("minor injustice"?)

@EpicOrange
Copy link
Contributor Author

EpicOrange commented Aug 27, 2023

  • when you lose points and ura is the difference between changing placement and not changing placement
  • discard a yakuhai dora and immediately draw the second

@EpicOrange
Copy link
Contributor Author

EpicOrange commented Aug 28, 2023

  • You were yakuman tenpai, didn't win, and would've won with a tsumo later had the game continued

Can't really check the wall after the game ends in tenhou, since for some reason that data is not given in the log file (not sure how to fetch it).

@peter1357908
Copy link
Member

peter1357908 commented Aug 28, 2023

Can't really check the wall after the game ends in tenhou, since for some reason that data is not given in the log file (not sure how to fetch it).

Maybe we eventually need to learn to fetch and parse the "full version" of a Tenhou log? For example, here is a game link and respective full version of the log:
https://tenhou.net/3/?log=2023082816gm-0089-0000-bb5ab5fe&tw=2
https://tenhou.net/0/log/?2023082816gm-0089-0000-bb5ab5fe

image

@EpicOrange
Copy link
Contributor Author

EpicOrange commented Sep 4, 2023

  • you started with a shanten 2+ worse than every other player
  • you started with 3+ dora while 4th place, but then someone else won a low value hand
  • someone else's all last tsumo pushed down your placement and ended the game
  • you had an early 8 outs ryanmen (or better) and never folded but the game went to ryuukyoku
  • you reached tenpai in at least 4 rounds and never won once (yakitori)
  • you had to deal with a triple riichi in which you are the one not in riichi (and you dealt in)
  • you are going for honitsu but drew 6+ off suit tiles in a row (not honors)
  • you started with a 1-4-7 shape in more than one suit
  • you kanned to give someone else 4 dora
  • you had a (good) 4+ sided wait and didn't win (not sure if 2223344 wait should count for this)
  • you only drew dangerous tiles (3+) after someone's riichi when you had no safe tiles in hand and are not in riichi (need to define a basic notion of dangerous: maybe non-genbutsu non-suji non-one-chance?)
  • your riichi was disrespected by all players (they all immediately threw dangerous tiles against you)

@EpicOrange
Copy link
Contributor Author

EpicOrange commented Sep 6, 2023

the following are just ideas, may not necessarily be injustices

  • you were iishanten and drew into tenpai but all your discard choices would lead to deal in, and you dealt in
  • you keep drawing honor tiles that you discard immediately (tsumogiri honors 6+ times in a row)
  • 1st place player keeps reaching tenpai (4+ rounds in a row)
  • you never reached tenpai first (or: ever)
  • someone with a 5-shanten start or worse reaches tenpai before your 2-shanten start or better, and they win
  • dealer tsumos 4+ times in a row
  • every time you reached tenpai you dealt in (2+ times)
  • you never dealt in but still ended up 4th (tsumos and noten payments)
  • the only reason you're 4th is because of oyakaburi
  • you never draw a single dora all game
  • your chii call would have put you into mangan+ tenpai but instead someone called pon/kan to override it
  • someone with more than 2x starting points disrespects your riichi
  • you lost every riichi to someone else winning first (3+ times)
  • someone's yakuman sent you from non-4th to 4th and ended the game prematurely (bust)
  • you had a 4-shanten start or worse, and after the first row of discards you're still 4-shanten or worse
  • it's all last and you need a baiman+ hand to advance your standing but you draw 4-shanten with no dora
  • pon calls skip your turn more than 3 times in a round
  • of all the haipai dora across rounds, one player drew at least half (and was first)
  • you dealt into chankan while tenpai
  • you drew 13579 or 2468 but couldn't fill a single kanchan
  • only bad waits won this game (0 good wait wins)

@EpicOrange
Copy link
Contributor Author

EpicOrange commented Sep 6, 2023

  • you called kan 3 times and didn't get any dora
  • your iishanten had 0 outs (at any point in time)
  • you had floating tile iishanten but all your floating tiles deal in and you dealt in
  • someone's ankan erased your tenpai wait
  • in all last you won a riichi hand and would have changed placement if you got more han from ippatsu/tsumo/ura, but you didn't get any and didn't change placement

@peter1357908
Copy link
Member

peter1357908 commented Sep 7, 2023

you are going for honitsu but drew 6+ off suit tiles in a row (not honors)

need to test to define what it means to be going for honitsu (> 8 applicable tiles? And/or discarding "good" tiles from off-suits?)

Also related:

  • maybe an injustice for tsumogiri 5+ times in a row, without being in tenpai? (this is a weaker version of the "6+ honor tsumogiri" in the second comment)

you kanned to give someone else 4 dora

More like a skill; not exactly injustice

you had a (good) 4+ sided wait

Yes; good being dependent on the number of outs?

you had an early 8 outs ryanmen (or better) and never folded but the game went to ryuukyoku

8-out may be too harsh; 7 is probably more applicable?

your riichi was disrespected by all players (they all immediately threw dangerous tiles against you)

(and you never won the riichi -- whether someone else won, etc.)

@peter1357908
Copy link
Member

peter1357908 commented Sep 7, 2023

you were iishanten and drew into tenpai but all your discard choices would lead to deal in, and you dealt in

This overlaps heavily with "you dealt in on the draw that got you into tenpai", so maybe combine them?

1st place player keeps reaching tenpai (4+ rounds in a row)
dealer tsumos 4+ times in a row
of all the haipai dora across rounds, one player drew at least half (and was first)

These are skills (i.e., injustice against everyone else)

Also some of these injustices are for the entire game (e.g., "never drew dora") so it'll probably do well to make a "closing comment".

only bad waits won this game (0 good wait wins)

Errr... this is a highlight, but not directly related to any particular player...

@peter1357908
Copy link
Member

you called kan 3 times and didn't get any dora

Across the entire game? Sankantsu is difficult to get dora already because of lack of tile variety in hand

someone's ankan erased your waits

Or at least, part of the waits (waits are usually fewer than than 7 tiles; erasing 4 tiles is very significant most of the time)

Idea:

  • you didn't win a hand and someone hoarded 4+ of your outs

@peter1357908
Copy link
Member

  • Going yakitori or only winning 1 small hand (<= 2-han) the whole game.

@EpicOrange
Copy link
Contributor Author

Can't really check the wall after the game ends in tenhou, since for some reason that data is not given in the log file (not sure how to fetch it).

Maybe we eventually need to learn to fetch and parse the "full version" of a Tenhou log? For example, here is a game link and respective full version of the log: https://tenhou.net/3/?log=2023082816gm-0089-0000-bb5ab5fe&tw=2 https://tenhou.net/0/log/?2023082816gm-0089-0000-bb5ab5fe

This functionality is now added

@peter1357908
Copy link
Member

  • dealing into ippatsu with tsumogiri or karagiri (i.e., drew the deal-in tile during ippatsu turn). Can be combined with being chased (already tenpai and/or riichi so having to tsumogiri).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants