Refactor initial seek #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
semver-patch
vweevers
commented
Oct 21, 2019
binding.cc
Outdated
| if (lt_->compare(dbIterator_->key().ToString()) <= 0) | ||
| dbIterator_->Prev(); | ||
| if (dbIterator_->key().compare(*lt_) >= 0) | ||
| assert(false); |
There was a problem hiding this comment.
@ralphtheninja @peakji Can you think of a case where we hit this code path?
peakji
approved these changes
Oct 22, 2019
vweevers
added a commit
to Level/rocksdb
that referenced
this pull request
Nov 4, 2019
Cherry-picked from Level/leveldown#689
83 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it more similar to the
OutOfRange()method used for manual seeks, and maybe merge that code eventually. With #680 in mind. Taking small steps on purpose.But I found what seems like dead code, see the second commit. I can't think of a case where we would hit this code path. Tried adding more tests too (I will open a
abstract-leveldownPR shortly).