Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 Compiler warning #26

Closed
rin67630 opened this issue Apr 13, 2021 · 2 comments
Closed

ESP32 Compiler warning #26

rin67630 opened this issue Apr 13, 2021 · 2 comments

Comments

@rin67630
Copy link

Setting my compiler to all messages I get this warning:

D:\5_Tinker\Arduino\libraries\Button2\src\Button2.cpp: In member function 'void Button2::loop()':
D:\5_Tinker\Arduino\libraries\Button2\src\Button2.cpp:181:11: warning: comparison is always true due to limited range of data type [-Wtype-limits]
   if (pin > -1) {
           ^

Since pin numbers are defined as uint8 this comparison seem to be reconsidered isn't it?

@LennartHennigs
Copy link
Owner

Hey, thanks for pointing this out.
Will update it.
Cheers.

@LennartHennigs
Copy link
Owner

pushed an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants