Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CSS issues with menu timer & changed color of settings #14

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: CSS issues with menu timer & changed color of settings #14

merged 1 commit into from
Feb 14, 2023

Conversation

aprilsbloom
Copy link
Contributor

CHANGES:

  • Changed the color of Crankshaft's settings to match Krunker's settings for consistency
  • Fixed the issues I accidentally introduced while refactoring some of the CSS files

IDEAS:

  • Implement an adblocker with a selection menu (I talked to you on Discord about this, not too experienced with TS so I haven't gotten anything to work)
    • This will have a list of 3 options - Off, Hide, and Remove
      • Hide value injects CSS to hide the ads
      • Remove value sets variables on the window to deny it from loading ads, as well as injecting the aforementioned CSS

@thegu5
Copy link
Contributor

thegu5 commented Feb 13, 2023

Dumb idea that might work - inject uBlock Origin into the electron app to handle ads

@KraXen72
Copy link
Owner

electron is notoriously bad at injecting chrome extensions, and uBlock would also block free kr ads, which i want to keep

@KraXen72 KraXen72 merged commit a4f5d2e into KraXen72:master Feb 14, 2023
@KraXen72
Copy link
Owner

testing revealed that krunker somehow disallows changing properties like canShowAds on the window object - normal (=) assignment or Object.assign don't work.
Wider-scale ad-block is not planned until someone finds a way to consistently change these values. the values:

window.canShowAds = false;
window.useAdinplayAds = false;
window.useFRANads = false;
window.useFreestarAds = false;
window.useFRVRSDKAds = false;
window.useFRVRSDKBannerAds = false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants