Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing IDs for entities other than Services, Routes, and Consumers #922

Open
1 task
czeslavo opened this issue May 30, 2023 · 0 comments
Open
1 task

Comments

@czeslavo
Copy link
Contributor

czeslavo commented May 30, 2023

Description

#918 has implemented support for changing IDs while keeping entities' names between deck syncs for Service, Route, and Consumer entities.

The goal of this issue is to implement similar behavior for every entity that still can be affected by the lack of this capability due to unique constraints enforced on some property of the entity other than its ID.

Affected entities:

  • Upstream (a unique constraint on name)
  • ... TBD

Proposed solution

Similarly to #918, implement DuplicatesDeleter interface in every entity's differ and generate Delete events once a duplicate is detected. Make sure that any implicit cascade deletes are handled in the entity's *PostAction.

Acceptance criteria

  • It's possible to run deck syncs twice, changing only the ID properties of all entities between each run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant