Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to PullRequest commits method #938

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Add parameters to PullRequest commits method #938

merged 2 commits into from
Nov 20, 2020

Conversation

seanmtaylor
Copy link
Contributor

Add a $parameters parameter to the PullRequest::commits() method to allow for pagination.

As per the docs: https://docs.github.com/en/free-pro-team@latest/rest/reference/pulls#list-commits-on-a-pull-request

@seanmtaylor seanmtaylor marked this pull request as ready for review November 19, 2020 22:00
@acrobat acrobat merged commit 1831db1 into KnpLabs:2.x Nov 20, 2020
@acrobat
Copy link
Collaborator

acrobat commented Nov 20, 2020

Thanks @seanmtaylor! And congrats on your first contribution! 🎉

acrobat added a commit that referenced this pull request Nov 20, 2020
* 2.x:
  Update branch alias
  feature #938 Add parameters to PullRequest commits method (seanmtaylor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants