Fix implicit nullable types to avoid PHP 8.4 warnings

[eiriksm]

No description provided.

[GrahamCampbell]

It's necessary to also run the CI on PHP 8.4.

[eiriksm]

It's necessary to also run the CI on PHP 8.4.

Done

[GrahamCampbell]

Looks like there are more issues to fix. It may be easier to enable the php-cs-fixer rule that adds the ? for you, to catch them all.

[eiriksm]

👍

I am writing this on an airport before boarding my plane, so just mentioning that because I will get back to this 🤓

[GrahamCampbell]

Looks like there are more downstream fixes that are needed first, to get this PR to pass.

[acrobat]

I've pushed some extra changes to fix most of the remaining issues. The deprecations in Http\Client\Common\HttpMethodsClient are fixed upstream but not yet releases. The http mock client still needs changes for this deprecation. I'm going to merge this PR for now as our code is deprecation free on php 8.4

[acrobat]

Thank you @eiriksm

[eiriksm]

Wow awesome thanks for the very fast response

Would it also be possible to cut a new release with this included do you think? 🤓

[acrobat]

New release is created https://github.com/KnpLabs/php-github-api/releases/tag/v3.15.0

[eiriksm]

My gratitude is deep and sincere ♥️

Thanks for being an open source maintainer, and a great one at that 🚀