Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify user when trying to launch nonexistent linked channel #1031

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Notify user when trying to launch nonexistent linked channel #1031

wants to merge 4 commits into from

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Sep 3, 2024 •
edited
Loading

Only warn when adding nonexistent julia install, as I find it useful to be able to add the link before I have the julia binary.

Fixes #979

@christiangnrd christiangnrd marked this pull request as ready for review September 3, 2024 20:29
davidanthoff
davidanthoff requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the check on launch we can do in some other way, but the check on link seems good as is.

src/bin/julialauncher.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nonexistent linked channels silently fail
2 participants
@christiangnrd @davidanthoff