Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QN: Validator profile scope changes #4905

Closed
2 tasks
thesan opened this issue Oct 2, 2023 · 2 comments
Closed
2 tasks

QN: Validator profile scope changes #4905

thesan opened this issue Oct 2, 2023 · 2 comments

Comments

@thesan
Copy link
Member

thesan commented Oct 2, 2023

Follow-up to #4823

Context

After discussing the Pioneer validator page it appeared that the initial scope was wrong:

  1. The Validator accounts are bound to a membership profile using the members.addStakingAccountCandidate / members.confirmStakingAccount extrinsics. As a result the accounts are not stored in the QN (they should be just retrieved directly from the chain). So both QN and protobufs validatorAccount fields introduced in Fix/4823 validator profile #4849 should be removed.
  2. The membership profile is what is being verified not the validator account. So the isVerifiedValidator from Fix/4823 validator profile #4849 should be kept but it should be reset to false whenever any membership metadata field is changed.
  3. The verification is the membership working group responsibility (not the HR group).

Scope

@eshark9312
Copy link
Contributor

eshark9312 commented Nov 23, 2023

@thesan

  1. The membership profile is what is being verified not the validator account. So the isVerifiedValidator from Fix/4823 validator profile #4849 should be kept but it should be reset to false whenever any membership metadata field is changed.
  2. The verification is the membership working group responsibility (not the HR group).

AFAIK, there is no tx to verify the validator membership with membership working group role.
Do we need to update the runtime?
Can we name the transaction api.tx.membershipWorkingGroup.verifyValidatorMembership or verifyValidatorProfile?

@thesan
Copy link
Member Author

thesan commented Nov 24, 2023

AFAIK, there is no tx to verify the validator membership with membership working group role. Do we need to update the runtime? Can we name the transaction api.tx.membershipWorkingGroup.verifyValidatorMembership or verifyValidatorProfile?

No need to modify the runtime because this verification is pure metadata (it only leaves in the QN). Here's the issue for it: #4824 and here's the PR #4868.

In short these extrinsics will be used: api.tx.operationsWorkingGroupBeta.workerRemark(workerId, msg) api.tx.membershipWorkingGroup.workerRemark(workerId, msg) and api.tx.operationsWorkingGroupBeta.leadRemark(msg) api.tx.membershipWorkingGroup.leadRemark(msg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants