From 53692a76340617ac4583102e546a87c405cecfa2 Mon Sep 17 00:00:00 2001 From: Benedikt Tutzer Date: Wed, 14 Jul 2021 15:44:31 +0200 Subject: [PATCH] Removed references to apache commons logging code-howtos and build.gradle still referenced apache commons, but slf4j should be used instead. CleanupUrlFormatter was the only class still using it, but never actually used the logger, so it was removed. --- build.gradle | 1 - docs/getting-into-the-code/code-howtos.md | 2 +- .../logic/formatter/bibtexfields/CleanupUrlFormatter.java | 4 ---- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/build.gradle b/build.gradle index 976b8e468cd..2291dc43900 100644 --- a/build.gradle +++ b/build.gradle @@ -649,7 +649,6 @@ jlink { provides 'org.mariadb.jdbc.credential.CredentialPlugin' with 'org.mariadb.jdbc.credential.aws.AwsIamCredentialPlugin', 'org.mariadb.jdbc.credential.env.EnvCredentialPlugin', 'org.mariadb.jdbc.credential.system.PropertiesCredentialPlugin' - provides 'org.apache.commons.logging.LogFactory' with 'org.apache.logging.log4j.jcl.LogFactoryImpl' provides 'org.slf4j.spi.SLF4JServiceProvider' with 'org.apache.logging.slf4j.SLF4JServiceProvider' provides 'org.apache.logging.log4j.spi.Provider' with 'org.apache.logging.log4j.core.impl.Log4jProvider' provides 'java.security.Provider' with 'org.bouncycastle.jce.provider.BouncyCastleProvider', diff --git a/docs/getting-into-the-code/code-howtos.md b/docs/getting-into-the-code/code-howtos.md index 93c779a5457..42f96fc958f 100644 --- a/docs/getting-into-the-code/code-howtos.md +++ b/docs/getting-into-the-code/code-howtos.md @@ -124,7 +124,7 @@ JabRef uses the logging facade [SLF4j](https://www.slf4j.org/). All log messages * Obtaining a logger for a class: ```java - private static final Log LOGGER = LogFactory.getLog(.class); + private static final Logger LOGGER = LoggerFactory.getLogger(.class); ``` * If the logging event is caused by an exception, please add the exception to the log message as: diff --git a/src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java b/src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java index 6f480ac40e1..e1299e520e9 100644 --- a/src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java +++ b/src/main/java/org/jabref/logic/formatter/bibtexfields/CleanupUrlFormatter.java @@ -8,15 +8,11 @@ import org.jabref.logic.cleanup.Formatter; import org.jabref.logic.l10n.Localization; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; - /** * Cleanup URL link */ public class CleanupUrlFormatter extends Formatter { - private static final Log LOGGER = LogFactory.getLog(CleanupUrlFormatter.class); // This regexp find "url=" or "to=" parameter in full link and get text after them private static final Pattern PATTERN_URL = Pattern.compile("(?:url|to)=([^&]*)");